🐛 Make generics work with SQLModel as base class #1275
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
svlandeg
added
bug
svlandeg
changed the title
Member
|
Thanks for the contribution! We're currently trying to catch up with the backlog of PRs, and will get back to you once we've had time to review this 🙏 |
YuriiMotov
approved these changes
Oct 29, 2025
Member
YuriiMotov
left a comment
YuriiMotov
left a comment
There was a problem hiding this comment.
LGTM!
Not completely understand how it works that __pydantic_** are injected into kwargs, but the fix works!
Code and tests look good!
github-actions
bot
added
the
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
conflicts
Refactor type hints to use built-in list instead of List from typing.
Removed the @needs_pydanticv2 decorator from test functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generics, as documented in pydantic's docs do not work.
Repro: Use the example from pydantic's docs. The typevar type does not get validated.
For example:
Response[int](data="not an int")does not raise an error.Furthermore, json schema generation is broken, as described here: #1002
This PR:
Related discussions: